Improve handling of failures to delete a WIP layer #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the attempts to recover from a failure themselves fail, we don't record that at all. That makes diagnosing the situation, or hypothetically detecting that the cleanup could never work, much harder. So, log the errors. Alternatively, we could include those failures as extra text in the returned error; that's less likely to be lost (e.g. a Go caller would have the extra text available, without setting up extra infrastructure to capture logs), but possibly harder to follow. Signed-off-by: Miloslav Trmač <[email protected]>
Account for the "diff != nil" path; try to remove even the metadata of a layer on a failure saving. Not that there's _much_ hope to be able to save the version without the new layer when we weren't able to save the version with the new layer. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/storage
that referenced
this pull request
Feb 22, 2022
Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.