Skip to content

Commit

Permalink
storage.conf: Don't specify nodev by default
Browse files Browse the repository at this point in the history
This reverts the default value of
8b1a0f8
but not the ability to specify options.

Doing `nodev` on `/` breaks previously valid configurations, such as using
`mock` inside a privileged container.  While it's easy for
such containers to learn to `mount -o remount,dev /`, it's a needless
compatibility break.

Rather, e.g. podman should learn to inject it only if it's known
safe to do so (e.g. the target container doesn't have CAP_MKNOD anyways).
  • Loading branch information
cgwalters committed Aug 20, 2018
1 parent 17c7d1f commit 669cb12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage.conf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ size = ""
override_kernel_check = "false"

# mountopt specifies comma separated list of extra mount options
mountopt = "nodev"
mountopt = ""

# Remap-UIDs/GIDs is the mapping from UIDs/GIDs as they should appear inside of
# a container, to UIDs/GIDs as they should appear outside of the container, and
Expand Down

0 comments on commit 669cb12

Please sign in to comment.