Merge pull request #1391 from alexlarsson/lockfiles-handle-partial-reads

Correctly handle lockfiles without writes
containers · Oct 17, 2022 · 54663e7 · 54663e7
2 parents ebf857f + ddb5de3
commit 54663e7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/lockfile/lockfile_unix.go b/pkg/lockfile/lockfile_unix.go
@@ -251,9 +251,10 @@ func (l *lockfile) Modified() (bool, error) {
 	if err != nil {
 		return true, err
 	}
-	if n != len(l.lw) {
-		return true, nil
-	}
+	// It is important to handle the partial read case, because
+	// the initial size of the lock file is zero, which is a valid
+	// state (no writes yet)
+	currentLW = currentLW[:n]
 	oldLW := l.lw
 	l.lw = currentLW
 	return !bytes.Equal(currentLW, oldLW), nil