lockfile: merge Seek+Read/Write into Pread/Pwrite

drop a call to Seek and use the Pread and Pwrite syscalls instead that already accept an offset. Signed-off-by: Giuseppe Scrivano <[email protected]>
containers · Jun 9, 2021 · 10afc92 · 10afc92
1 parent 39e7061
commit 10afc92
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/pkg/lockfile/lockfile_unix.go b/pkg/lockfile/lockfile_unix.go
@@ -194,11 +194,7 @@ func (l *lockfile) Touch() error {
 	defer l.stateMutex.Unlock()
 	l.lw = stringid.GenerateRandomID()
 	id := []byte(l.lw)
-	_, err := unix.Seek(int(l.fd), 0, os.SEEK_SET)
-	if err != nil {
-		return err
-	}
-	n, err := unix.Write(int(l.fd), id)
+	n, err := unix.Pwrite(int(l.fd), id, 0)
 	if err != nil {
 		return err
 	}
@@ -217,11 +213,7 @@ func (l *lockfile) Modified() (bool, error) {
 		panic("attempted to check last-writer in lockfile without locking it first")
 	}
 	defer l.stateMutex.Unlock()
-	_, err := unix.Seek(int(l.fd), 0, os.SEEK_SET)
-	if err != nil {
-		return true, err
-	}
-	n, err := unix.Read(int(l.fd), id)
+	n, err := unix.Pread(int(l.fd), id, 0)
 	if err != nil {
 		return true, err
 	}