Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make InspectOutput an external object #992

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Make InspectOutput an external object #992

merged 1 commit into from
Aug 3, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 26, 2020

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan rhatdan mentioned this pull request Jul 26, 2020
Closed
@mtrmac
Copy link
Contributor

mtrmac commented Jul 27, 2020

Discussion in #990, for the record.

@rhatdan
Copy link
Member Author

rhatdan commented Aug 1, 2020

@vrothberg PTAL

vrothberg
vrothberg reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan rhatdan merged commit c052ed7 into containers:master Aug 3, 2020
@mtrmac mtrmac mentioned this pull request Aug 8, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhatdan @mtrmac @TomSweeneyRedHat @vrothberg