Re-vendor, notably opencontainers/image-spec to fix tests #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Alternatively, we could leave the repo as is, and just keep telling people to run |
mtrmac
force-pushed
the
oci-schema-rebase
branch
2 times, most recently
from
d358311 to
f152660
Compare
mtrmac
force-pushed
the
oci-schema-rebase
branch
from
f152660 to
09beda1
Compare
mtrmac
changed the title
Anyone running (vndr) currently ends up with failing tests in OCI schema validation because gojsonschema has fixed its "$ref" interpretation, exposing inconsistent URI usage inside image-spec/schema. So, this runs (vndr), and uses mtrmac/image-spec:id-based-loader ( opencontainers/image-spec#739 ) to make the tests pass again. As soon as that PR is merged we should revert to using the upstream image-spec repo again.
mtrmac
force-pushed
the
oci-schema-rebase
branch
from
09beda1 to
dc1567c
Compare
|
@runcom PTAL. The fix has been merged upstream, so this is primarily a rebase of |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone running
(vndr)currently ends up with failing tests in OCI schema validation becausegojsonschemahas fixed its"$ref"interpretation, exposing inconsistent URI usage insideimage-spec/schema.So, this runs
(vndr), and usesmtrmac/image-spec:id-based-loader( opencontainers/image-spec#739 ) to make the tests pass again. As soon as that PR is merged we should revert to using the upstream image-spec repo again.