[release-1.4] Don't expect the config blob to be listed in (skopeo inspect) #1575
Conversation
... because it currently isn't. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
|
|
||
| # Each SHA-named layer file (but not the config) must be listed in the output of 'inspect'. | ||
| # As of Skopeo 1.6, (skopeo inspect)'s output lists layer digests, | ||
| # but not the digest of the config blob ($config_digest), if any. |
There was a problem hiding this comment.
Non-blocking: This is the 1.4 branch, so the comment is slightly confusing. Is it saying "Prior to 1.6, the output also included the digest of the config blob"?
There was a problem hiding this comment.
It is meant to say “as of all existing versions to date, up to and including 1.6”.
systemtest/010-inspect.bats
Outdated
| config_digest=$(jq -r '.config.digest' <<<"$inspect_local_raw") | ||
|
|
||
| # Each SHA-named layer file (but not the config) must be listed in the output of 'inspect'. | ||
| # As of Skopeo 1.6, (skopeo inspect)'s output lists layer digests, |
There was a problem hiding this comment.
| # As of Skopeo 1.6, (skopeo inspect)'s output lists layer digests, | |
| # As of Skopeo 1.6, (skopeo inspect's) output lists layer digests, |
There was a problem hiding this comment.
Although I think I'd just dro the parens all together.
There was a problem hiding this comment.
The parens are a somewhat-weird habit to quote shell commands in a way where copy-pasting both with and without the parens is a valid shell command (unlike using ", or ', let alone typographically-correct quotes); so moving the 's inside doesn’t work.
The parens are an habit from a specific niche period of the Fedora IRC universe, obscure enough to be confusing, I’ll drop them.
|
Doc nits for consideration, ditto 1.13 variant. LGTM otherwise and I'd be fine with the docs as is. |
|
These PRs are supposed to be backports — I’ll prepare fixes on the main branch, and add them to these PRs. |
#1576 . |
Signed-off-by: Miloslav Trmač <[email protected]>
|
Updated by adding #1576. |
|
LGTM |
This a backport of #1572 to fix CI on this branch.