-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about multi-arch image to README #1110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
@barthy1 a few tiny nits scattered about, otherwise it looks great. Thanks so much for whipping this up so quickly! |
and now needs a rebase to boot. |
Also update to the correct one information about required env variables for multi-arch build Signed-off-by: Yulia Gaponenko <[email protected]>
- rename skopeo to Skopeo - improve language Co-authored-by: Tom Sweeney <[email protected]>
barthy1
force-pushed
the
multi_arch_doc
branch
from
November 19, 2020 17:24
7729a42
to
4b4ad62
Compare
@TomSweeneyRedHat thank you for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @barthy1 !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update to the correct one information about required env variables
for multi-arch build
Signed-off-by: Yulia Gaponenko [email protected]