Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about multi-arch image to README #1110

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

barthy1
Copy link
Contributor

@barthy1 barthy1 commented Nov 19, 2020

Also update to the correct one information about required env variables
for multi-arch build

Signed-off-by: Yulia Gaponenko [email protected]

@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2020

LGTM
@TomSweeneyRedHat @vrothberg PTAL

release/README.md Outdated Show resolved Hide resolved
release/README.md Outdated Show resolved Hide resolved
release/README.md Outdated Show resolved Hide resolved
release/README.md Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

@barthy1 a few tiny nits scattered about, otherwise it looks great. Thanks so much for whipping this up so quickly!

@TomSweeneyRedHat
Copy link
Member

and now needs a rebase to boot.

barthy1 and others added 2 commits November 19, 2020 18:23
Also update to the correct one information about required env variables
for multi-arch build

Signed-off-by: Yulia Gaponenko <[email protected]>
- rename skopeo to Skopeo
- improve language

Co-authored-by: Tom Sweeney <[email protected]>
@barthy1
Copy link
Contributor Author

barthy1 commented Nov 19, 2020

@TomSweeneyRedHat thank you for review.
Done :)

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @barthy1 !

@rhatdan rhatdan merged commit 0f4dc80 into containers:master Nov 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants