make fails on centos7

[vbatts]

I've installed the podman rpm (podman-0.9.2-5.git37a2afe.el7_5.x86_64) to ensure all dependencies are present, and then built&installed podman master

$ podman version
Version:       0.10.2-dev
Go Version:    go1.11
Git Commit:    "76360d9a6ef73f694138766b81f380e45a860556"
Built:         Mon Nov  5 12:44:35 2018
OS/Arch:       linux/amd64

When I attempt to make skopeo master (187299a) it fails at this point:

STEP 7: COMMIT skopeobuildimage
/usr/local/bin/podman run --rm --security-opt label:disable -v $(pwd):/src/github.com/containers/skopeo \
        skopeobuildimage make binary-local  BUILDTAGS='  '
Invalid --security-opt 1: "label:disable"
make: *** [binary] Error 125

[rhatdan]

--security-opt label=disable

Podman only supports the label=, not the label:

[mtrmac]

Thanks, fixed — but you almost certainly want make binary-local to get a locally usable binary instead of an Ubuntu-dependent dynamically linked one.

@rhatdan @runcom Should we make local builds the default target?

I’m even seriously tempted to just drop the in-container build targets altogether… we don’t use it, and it shows.

[vbatts]

I think the local build should always be default

…

On Thu, Nov 8, 2018, 15:27 Miloslav Trmač ***@***.*** wrote: Thanks, fixed — but you almost certainly want make binary-local to get a locally usable binary instead of an Ubuntu-dependent dynamically linked one. @rhatdan <https://github.com/rhatdan> @runcom <https://github.com/runcom> Should we make local builds the default target? I’m even seriously tempted to just drop the in-container build targets altogether… we don’t use it, and it shows. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#567 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEF6XksMkp1djUZwyZsazIScDuFvOTKks5utJO1gaJpZM4YSh72> .

[rhatdan]

@mtrmac Yes local should be the default.

[vorburger]

--security-opt label=disable : Podman only supports the label=, not the label:

Thanks for recording this here; it helped to fix kubernetes/test-infra#13045.