Adding comments for container options in qm.container #678
Conversation
Signed-off-by: Ilia Markelov <[email protected]>
ilimarx
force-pushed
the
qm_container_doc
branch
from
c5f38a8 to
0b5ca68
Compare
| @@ -35,10 +35,24 @@ LimitNOFILE=65536 | |||
| TasksMax=50% | |||
|
|
|||
| [Container] | |||
| # AddCapability | |||
There was a problem hiding this comment.
I would recommend here to use man quadlet also for details
There was a problem hiding this comment.
Tried to copy some details from man quadlet, hope it's better now
There was a problem hiding this comment.
Consider adding this link to upstream doc
https://docs.podman.io/en/v4.4/markdown/podman-systemd.unit.5.html#addcapability
for each Capability
Or that one, it is more accurate
man quadlet | awk '/AddCapability=$/,/^$/'
MHO it more accurate then copy paste content of changing description.
It could also be automated to check if parameters were changed,
I mean file parameters vs existence in manual
There was a problem hiding this comment.
Added a link to the comment for AddCapability option. Not sure about the "upstream doc", I was told to write comments for options.
There was a problem hiding this comment.
If some on told you, this is the place to comment it
| # AddCapability | ||
| # ------------- | ||
| # Grants all capabilities to the container, increasing flexibility but significantly | ||
| # reducing security. | ||
| AddCapability=all |
There was a problem hiding this comment.
Thanks, last comments related to that,
Consider thinking of man command , repo is upstream code, that could run against different podman versions, this way, in case of qm failures due to quadlet file, user can check the installed qudlet manual and refer the supported capabilities.
… qm_container_doc
|
@ilimarx please squash all commits. this change should be one commit |
No description provided.