Add qm-is-ostree script installation and RPM packaging #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Makefile to install the qm-is-ostree script to ${DATADIR}/qm/
- Modified qm.spec to include qm-is-ostree in the install and package files
- Added the qm-is-ostree script to the RPM preuninstall stepsw
Signed-off-by: Rakesh Musalay <[email protected]>
RakeshMK90
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
sandrobonazzola,
nsednev,
aesteve-rh,
pengshanyu and
kleinffm
as code owners
dougsland
reviewed
Oct 11, 2024
dougsland
reviewed
Oct 11, 2024
Signed-off-by: Rakesh Musalay <[email protected]>
|
@RakeshMK90 from my side looks good let's hear from others too, we need one +1 at least. @Yarboa @aesteve-rh @sandrobonazzola Good work, thanks ! |
|
I'm not sure that we really need braces around the variable OSTREE_PATH. |
nsednev
reviewed
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rakesh Musalay [email protected]
Address the issue #586
Summary of Changes
Makefile Updates:
Added a new installation step for the qm-is-ostree script.
The script tools/qm-is-ostree is installed as qm-is-ostree with executable permissions (755) to the target directory ${DATADIR}/qm/.
RPM Spec File (qm.spec) Modifications:
Added an entry to install the qm-is-ostree script in the %install section at /usr/share/qm/qm-is-ostree.
Updated the list of packaged files to include %{_datadir}/qm/qm-is-ostree, ensuring the script is tracked as part of the package.
Added the new script qm-is-ostree to the %preun section, indicating that it may be involved in uninstallation steps.