Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Disable oom_score_adj on prepare_test #472

Merged

Conversation

telemaco
Copy link
Contributor

@telemaco telemaco commented Jul 1, 2024

The prepare_test fuction overrides the OOMScoreAdjust value. That should be performed if necessary through systemd drop-in files.

The prepare_test fuction overrides the OOMScoreAdjust value. That should
be performed if necessary through systemd drop-in files.

Signed-off-by: Roberto Majadas <[email protected]>
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will be removed, once this part is resolved
#473

@Yarboa
Copy link
Collaborator

Yarboa commented Jul 1, 2024

It seems that in disk test,
OOMScoreAdjust=1000 is working while the default https://github.com/containers/qm/blob/main/qm.container#L13
is not triggering oom_killer

this tests is failing
https://github.com/containers/qm/blob/main/tests/ffi/disk/test.sh

Machine crash,
I would like to review scoring mechanism

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa Yarboa merged commit 7f03a18 into containers:main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants