Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM: set AllowedCPUs in quadlet file post install #25

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 27, 2023

Fixes: #24

@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

let me try out the packit rpms on a gce instance.

@lsm5 lsm5 marked this pull request as ready for review April 27, 2023 14:35
@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

works well on c9s on GCE with nproc=2

@rhatdan PTAL

@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

err wait...

@lsm5 lsm5 marked this pull request as draft April 27, 2023 14:36
@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

I guess this is good to go. qm.service is still failing on /dev/kvm not found, but that should be fixed once containers/podman#18378 is merged and built on copr.

@lsm5 lsm5 marked this pull request as ready for review April 27, 2023 15:01
@lsm5 lsm5 changed the title [DO NOT MERGE] RPM: set AllowedCPUs in quadlet file post install RPM: set AllowedCPUs in quadlet file post install Apr 27, 2023
@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

@rhatdan PTAL, ready now

I guess this is good to go. qm.service is still failing on /dev/kvm not found, but that should be fixed once containers/podman#18378 is merged and built on copr.

The podman PR cherry-pick will merge anytime now and will soon be available on rhcontainerbot/qm copr.

@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2023

Can you make %{_datadir}/containers/systemd/qm.container
Config(noreplace)

@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

Can you make %{_datadir}/containers/systemd/qm.container Config(noreplace)

sure thing

Also set %%{_datadir}/containers/systemd/qm.container as
%%config(noreplace).

Fixes: containers#24

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the custom-allowed-cpus branch from cfbd564 to 3d7ae4c Compare April 27, 2023 17:25
@lsm5
Copy link
Member Author

lsm5 commented Apr 27, 2023

@rhatdan done

@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2023

👍

@rhatdan rhatdan merged commit e71b6d5 into containers:main Apr 27, 2023
@lsm5 lsm5 deleted the custom-allowed-cpus branch April 28, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set AllowedCPUs= by detecting number of cpus on target system
2 participants