Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psgo: add RSS format #69

Merged
merged 1 commit into from
Apr 9, 2020
Merged

psgo: add RSS format #69

merged 1 commit into from
Apr 9, 2020

Conversation

leahneukirchen
Copy link
Contributor

An obvious addition.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code looks good. One tests needs to be updated (https://travis-ci.org/github/containers/psgo/builds/669760859#L340).

@leahneukirchen
Copy link
Contributor Author

What is the CI fail here? Is it related to the patch?

@vrothberg
Copy link
Member

Rebasing ontop of the latest master should turn it green.

Signed-off-by: Leah Neukirchen <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your work!

@vrothberg vrothberg merged commit 7686e6f into containers:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants