Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest API endpoints #9969

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Update manifest API endpoints #9969

merged 1 commit into from
Apr 12, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Apr 7, 2021

  • Add validation for manifest name
  • Always return an array for manifests even if empty

When c/image is refactored to include manifests, these endpoints should
be revisited.

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added kind/bug Categorizes issue or PR as related to a bug. HTTP API Bug is in RESTful API labels Apr 7, 2021
@jwhonce jwhonce requested review from nalind and baude April 7, 2021 18:05
@jwhonce jwhonce self-assigned this Apr 7, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@jwhonce jwhonce force-pushed the wip/manifests branch 4 times, most recently from 39bf8bf to 7a376b2 Compare April 9, 2021 15:06
@jwhonce jwhonce requested a review from vrothberg April 9, 2021 15:10
@jwhonce
Update manifest API endpoints
d41c33e 
* Add validation for manifest name
* Always return an array for manifests even if empty
* Add missing return in df handler when returning error. Caused an
  additional null to be written to client crashing python decoder.

When c/image is refactored to include manifests, manifest endpoints should
be revisited.

Signed-off-by: Jhon Honce <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Apr 12, 2021

LGTM

@mheon
Copy link
Member

mheon commented Apr 12, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit bd3dcb9 into containers:master Apr 12, 2021
@edsantiago edsantiago mentioned this pull request Apr 14, 2021
Closed
@edsantiago edsantiago mentioned this pull request Jul 13, 2021
Open
@jwhonce jwhonce deleted the wip/manifests branch September 29, 2021 16:09
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nalind nalind Awaiting requested review from nalind

@baude baude Awaiting requested review from baude

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@jwhonce jwhonce

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwhonce @openshift-ci-robot @rhatdan @mheon @openshift-merge-robot