[CI:DOCS] Restore rootless-cni-infra contrib info #9946
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
PR #9423 removed the contrib/rootless-cni-infra directory and it's files and should not have. The information in that tree is required for Podman v3.0 and earlier users, and primarily those in RHEL 8.4.0 and 8.3.1. This PR puts those files back and adds a note to the README.md noting the changes are not needed for versions after Podman v3.0. Signed-off-by: TomSweeneyRedHat <[email protected]>
TomSweeneyRedHat
changed the title
|
NACK. This is unnecessary. We are pointing people at the long-term support branches, not master, for the image. We should not continue to maintain this readme and image. |
|
I'll buy the NACK when you show me where we're pointing people to find this info.... Someone running into this on Podman 2.2 I don't think will find it unless it's on master. |
|
We point them at the specific release branch. From our 2.2.1 RHEL branch - 4007554 points people to https://github.com/containers/podman/blob/v2.2.1-rhel/contrib/rootless-cni-infra/ - that's not master, that's the v2.2.1-rhel branch. We did this deliberately to ensure they pulled a version of the infra image that matched their Podman. v3.0.1 is the same. |
github-actions
bot
added
the
locked - please file new issue/PR
PR #9423 removed the contrib/rootless-cni-infra directory and
it's files and should not have. The information in that tree
is required for Podman v3.0 and earlier users, and primarily
those in RHEL 8.4.0 and 8.3.1.
This PR puts those files back and adds a note to the README.md
noting the changes are not needed for versions after Podman v3.0.
Signed-off-by: TomSweeneyRedHat [email protected]