Fix rootlesskit port forwarder with custom slirp cidr #9941
Conversation
openshift-ci-robot
added
the
approved
|
@Luap99 looks like some tests aren't happy with these changes. |
|
LGTM |
| @@ -391,6 +391,16 @@ func (r *Runtime) setupRootlessPortMappingViaRLK(ctr *Container, netnsPath strin | |||
| } | |||
|
|
|||
| childIP := slirp4netnsIP | |||
There was a problem hiding this comment.
Can we remove this const slirp4netnsIP = "10.0.2.100"?
There was a problem hiding this comment.
If the slirp cidr is omitted, we still need the default ip.
There was a problem hiding this comment.
If we have the default CIDR string (10.0.2.0/24), we no longer need the default IP string.
There was a problem hiding this comment.
OK but than we just changed the ip with a subnet.
openshift-ci
bot
added
the
needs-rebase
The source ip for the rootlesskit port forwarder was hardcoded to the standard slirp4netns ip. This is incorrect since users can change the subnet used by slirp4netns with `--network slirp4netns:cidr=10.5.0.0/24`. The container interface ip is always the .100 in the subnet. Only when the rootlesskit port forwarder child ip matches the container interface ip the port forwarding will work. Fixes containers#9828 Signed-off-by: Paul Holzinger <[email protected]>
openshift-ci
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
The source ip for the rootlesskit port forwarder was hardcoded to the
standard slirp4netns ip. This is incorrect since users can change the
subnet used by slirp4netns with
--network slirp4netns:cidr=10.5.0.0/24.The container interface ip is always the .100 in the subnet. Only when
the rootlesskit port forwarder child ip matches the container interface
ip the port forwarding will work.
Fixes #9828