Add support for play/generate kube PersistentVolumeClaims and Podman volumes

[EduardoVega]

Signed-off-by: Eduardo Vega [email protected]

This PR provides the ability to support Kubernetes PersistentVolumeClaims for podman play or generate kube. A k8s PersistentVolumeClaim represents a Podman volume, only the PVC name is required to create the volume. Podman volume options can be set using PVC annotations.

This is based on this PR #8266 and related to this Issue #5788.

[TomSweeneyRedHat]

@EduardoVega looks like you've some trailing space issues.
Otherwise this LGTM

[rhatdan]

/approve
@umohnani8 @haircommander PTAL

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EduardoVega, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[haircommander]

2 questions for consideration:

• should these be kept as constants anywhere?
• often, these special annotations follow the format of a url: io.podman.volume does it make sense to apply that here?

[EduardoVega]

1. Let me change that.
2. You're correct. The url format does not provide any special functionality but it is better to stick to the k8s syntax. What about something like this volume.podman.io/driver based on node.kubernetes.io/instance-type?

[EduardoVega]

This has been changed.

[haircommander]

A couple of questions but none of them blocking. This looks great @EduardoVega, I especially like the idea about using annotations to get special podman options

[rhatdan]

/lgtm

[rhatdan]

Thanks @EduardoVega