Add support for podman --context default #9907
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
cmd/podman/root.go
Outdated
| @@ -269,6 +269,9 @@ func rootFlags(cmd *cobra.Command, opts *entities.PodmanConfig) { | |||
| lFlags.StringVar(&opts.URI, urlFlagName, uri, "URL to access Podman service (CONTAINER_HOST)") | |||
| _ = cmd.RegisterFlagCompletionFunc(urlFlagName, completion.AutocompleteDefault) | |||
|
|
|||
| // Context option added just for compatibily with DockerCLI. | |||
| lFlags.String("context", "", "Name of the context to use to connect to the daemon (This flag is a NOOP and provided solely for scripting compatibility.)") | |||
There was a problem hiding this comment.
I actually had that originally but was not crazy about it since it showed on the help message. But I can add it back.
There was a problem hiding this comment.
I think we should hide the flag and not document it. It doesn't add value since it only accepts one value. But I think it adds great value for cases as in the initial issue.
cmd/podman/root.go
Outdated
| @@ -180,6 +180,10 @@ func persistentPreRunE(cmd *cobra.Command, args []string) error { | |||
| os.Setenv("TMPDIR", "/var/tmp") | |||
| } | |||
|
|
|||
| context := cmd.Root().LocalFlags().Lookup("context") | |||
| if context.Value.String() != "default" { | |||
| return errors.New("Podman does not support swarm, only --context value allowed is \"default\"") | |||
There was a problem hiding this comment.
soft suggestion
| return errors.New("Podman does not support swarm, only --context value allowed is \"default\"") | |
| return errors.New("Podman does not support swarm, the only --context value allowed is \"default\"") |
|
All kinds of unhappy tests. |
rhatdan
force-pushed
the
options
branch
2 times, most recently
from
b2601ab to
f3f1a9d
Compare
This is a noop but helps with scripting and docker-compose. Fixes: containers#9806 Signed-off-by: Daniel J Walsh <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
This is a noop but helps with scripting and docker-compose.
Fixes: #9806
Signed-off-by: Daniel J Walsh [email protected]