Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Cirrus: Add Ubuntu to rootless integration testing #9905

Closed
wants to merge 2 commits into from

Conversation

cevich
Copy link
Member

@cevich cevich commented Mar 31, 2021

Fixes #9508

Signed-off-by: Chris Evich [email protected]

@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2021

LGTM
I like more tests.

@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2021

Sadly test are breaking.

@cevich
Copy link
Member Author

cevich commented Mar 31, 2021

Sadly test are breaking.

That's a matter of perspective; One could say the tests have freshly uncovered previously hidden problems 😁

Let's see what we got going on here...

@cevich
Copy link
Member Author

cevich commented Mar 31, 2021

...okay, these appear like fairly clear problems:

  • For Ubuntu 20.10 (crun), only one test failed with a pretty clear error: error starting container a7a...6c2: the requested cgroup controller cpu is not available: OCI runtime error. Assuming that means some thing like "The kernel is too old", maybe this is a test we can simply skip on Ubuntu 20.10?
  • For Ubuntu 20.04 (runc), all the errors are capability related, so again perhaps a "kernel is too old" issue. @rhatdan what do we do in case of Error: OCI runtime error: container_linux.go:367: starting container process caused: unknown capability "CAP_PERFMON"?

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2021

The Error: OCI runtime error: container_linux.go:367: starting container process caused: unknown capability "CAP_PERFMON" error only happens in network tests. I completely rework rootless networking in #9423. Maybe it will work with the new networking logic. I added this commit to my PR lets see if it will work there.

@cevich
Copy link
Member Author

cevich commented Mar 31, 2021

@Luap99 thanks! I also have two PRs to update the VM images, both are stuck waiting for an updated crun, which could (maybe) have some bearing here, esp. on the first (Ubuntu 20.10) problem.

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2021

@edsantiago
Copy link
Member

New map: cirrus-map-pr9905

@cevich
Copy link
Member Author

cevich commented Mar 31, 2021

@Luap99 excellent news, does it also pass standalone and/or do you want me to rebase this?

@giuseppe or @rhatdan any ideas on the error starting container a7a...6c2: the requested cgroup controller 'cpu' is not available: OCI runtime error?

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2021

@cevich I think the fix for the cpu cgroup controller failure is just to skip the test, see:

It("podman play kube allows setting resource limits", func() {
SkipIfContainerized("Resource limits require a running systemd")
SkipIfRootlessCgroupsV1("Limits require root or cgroups v2")
SkipIfUnprivilegedCPULimits()

However the SkipIfUnprivilegedCPULimits only skips when rootless on fedora
func SkipIfUnprivilegedCPULimits() {
info := GetHostDistributionInfo()
if isRootless() && info.Distribution == "fedora" {
ginkgo.Skip("Rootless Fedora doesn't have permission to set CPU limits")
}
}

So I guess we have to add ubuntu 20.10 there as well.

@cevich
Copy link
Member Author

cevich commented Mar 31, 2021

So I guess we have to add ubuntu 20.10 there as well.

Ahh perfect. @giuseppe or @rhatdan un-ping, and sorry for the noise. Let's see if we can just remove && info.Distribution == "fedora"...

@cevich cevich force-pushed the rootless_ubuntu_testing branch from 6fd1ab1 to c180ec3 Compare March 31, 2021 21:47
@cevich cevich changed the title Cirrus: Add Ubuntu to rootless integration testing WIP: Cirrus: Add Ubuntu to rootless integration testing Mar 31, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2021
@cevich cevich force-pushed the rootless_ubuntu_testing branch 2 times, most recently from 0bd2f41 to dbd04b9 Compare April 2, 2021 12:43
@cevich
Copy link
Member Author

cevich commented Apr 2, 2021

Rebased onto #9423 then again onto master.

@cevich cevich force-pushed the rootless_ubuntu_testing branch 2 times, most recently from 070617f to e9b4d1d Compare April 9, 2021 18:59
@cevich cevich force-pushed the rootless_ubuntu_testing branch 2 times, most recently from 35fd65d to c3d614d Compare April 13, 2021 15:03
@cevich cevich force-pushed the rootless_ubuntu_testing branch from c3d614d to 5bc6dcc Compare April 20, 2021 15:25
@cevich
Copy link
Member Author

cevich commented Apr 20, 2021

Rebased on master

@cevich cevich force-pushed the rootless_ubuntu_testing branch from 5bc6dcc to ffccbe9 Compare April 21, 2021 18:46
@cevich
Copy link
Member Author

cevich commented Apr 21, 2021

Rebased on master

@cevich
Copy link
Member Author

cevich commented Apr 26, 2021

Blocked by #9997

cevich added 2 commits May 6, 2021 11:42
The test also needs to be skipped for rootless Ubuntu.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the rootless_ubuntu_testing branch from ffccbe9 to 509b6d2 Compare May 6, 2021 15:42
@cevich
Copy link
Member Author

cevich commented May 6, 2021

Rebased on master

@cevich
Copy link
Member Author

cevich commented May 7, 2021

Obsolete by #10237

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2021

@cevich: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2021
@rhatdan rhatdan closed this May 9, 2021
@cevich cevich deleted the rootless_ubuntu_testing branch June 30, 2021 17:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: CI rootless ubuntu tests
5 participants