-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Cirrus: Add Ubuntu to rootless integration testing #9905
Conversation
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sadly test are breaking. |
That's a matter of perspective; One could say the tests have freshly uncovered previously hidden problems 😁 Let's see what we got going on here... |
...okay, these appear like fairly clear problems:
|
The |
@Luap99 thanks! I also have two PRs to update the VM images, both are stuck waiting for an updated |
Ubuntu 20.04 works with my PR https://github.com/containers/podman/pull/9423/checks?check_run_id=2238965171. |
@cevich I think the fix for the cpu cgroup controller failure is just to skip the test, see: podman/test/e2e/play_kube_test.go Lines 1830 to 1833 in 5798102
However the SkipIfUnprivilegedCPULimits only skips when rootless on fedorapodman/test/e2e/common_test.go Lines 608 to 613 in 5798102
So I guess we have to add ubuntu 20.10 there as well. |
6fd1ab1
to
c180ec3
Compare
0bd2f41
to
dbd04b9
Compare
Rebased onto #9423 then again onto master. |
070617f
to
e9b4d1d
Compare
35fd65d
to
c3d614d
Compare
c3d614d
to
5bc6dcc
Compare
Rebased on master |
5bc6dcc
to
ffccbe9
Compare
Rebased on master |
Blocked by #9997 |
Signed-off-by: Chris Evich <[email protected]>
The test also needs to be skipped for rootless Ubuntu. Signed-off-by: Chris Evich <[email protected]>
ffccbe9
to
509b6d2
Compare
Rebased on master |
Obsolete by #10237 |
@cevich: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #9508
Signed-off-by: Chris Evich [email protected]