Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Fix unmount doc reference in image.rst #9901

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[CI:DOCS] Fix unmount doc reference in image.rst #9901

merged 1 commit into from
Mar 31, 2021

Conversation

w4tsn
Copy link
Contributor

@w4tsn w4tsn commented Mar 31, 2021 •
edited
Loading

This pointed to the container-unmount doc page. It now points to the
expected podman-image-unmount doc page.

Currently deployed version with wrong link: http://docs.podman.io/en/latest/image.html

Luap99
Luap99 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@Luap99
Copy link
Member

Luap99 commented Mar 31, 2021

Thanks @w4tsn. You have to sign your commit. git commit -s --amend and force push.

@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2021

LGTM
Are these files autogenerated?

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2021 •
edited
Loading

Are these files autogenerated?

No

@w4tsn
Fix unmount doc reference in image.rst
6fa1c7e 
This pointed to the container-unmount doc page. It now points to the
expected podman-image-unmount doc page.

Signed-off-by: Alexander Wellbrock <[email protected]>
@w4tsn w4tsn force-pushed the docs/fix-podman-image-unmount-link branch from 11ed24a to 6fa1c7e Compare March 31, 2021 14:00
@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2021

/approve
/lgtm

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan, w4tsn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e5f0869 into containers:master Mar 31, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@w4tsn @Luap99 @rhatdan @openshift-ci-robot @openshift-merge-robot