Fix #9698 Updated reference to network #9899
Conversation
|
LGTM
…On Tue, Mar 30, 2021 at 19:18 OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *kellen-dunham
<#9899#>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please assign *zhangguanzhang* after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhangguanzhang in a
comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=containers%2Fpodman>.
Needs approval from an approver in each of these files:
- *OWNERS <https://github.com/containers/podman/blob/master/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCGS555DUDS4IGYZ5IDTGJL2PANCNFSM42DF3V5Q>
.
|
|
@mheon @rhatdan @TomSweeneyRedHat I can't seem to get the PR checks to work ... seems to be caught up in validating the DCO however I believe the DCO is there on the commit message? Any suggestions, thanks! |
|
You need a line break between your title and your signature. This is also going to need tests or the [NO TESTS NEEDED] flag. |
|
Could you rebase your PR git pull origin master |
Updated reference to network [NO TESTS NEEDED] Signed-off-by: Kellen Dunham <[email protected]>
|
@rhatdan Thanks for the help, I appreciate it! I'm not sure what to do about the failing task though it doesn't appear to be related to the code change since there are no --network flags being tested. |
|
Restarted the ubuntu-2004 root test, it looked like a time out/flake trying to stop a container. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kellen-dunham, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Kellen Dunham [email protected]