Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman machine ls #9885

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

ashley-cui
Copy link
Member

podman machine ls lists all virtual machines & indicates the default VM
connection, if it exists. it also can take a --format flag arg as a go
template.

[NO TESTS NEEDED]

Signed-off-by: Ashley Cui [email protected]

@baude
Copy link
Member

baude commented Mar 30, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@TomSweeneyRedHat
Copy link
Member

all kinds of red unhappiness in the tests.

pkg/machine/qemu/machine.go Outdated Show resolved Hide resolved
cmd/podman/machine/list.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021
@ashley-cui ashley-cui force-pushed the machinels branch 2 times, most recently from 2750ac1 to a9af0b2 Compare March 30, 2021 17:15
cmd/podman/machine/list.go Outdated Show resolved Hide resolved
docs/source/markdown/podman-machine-ls.1.md Outdated Show resolved Hide resolved
cmd/podman/machine/list.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2021

The command should be list, not ls

podman container list
podman image list
podman volume list
podman pod list

@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2021

You can alias ls, but we should document list.

@baude
Copy link
Member

baude commented Mar 30, 2021

LGTM

cmd/podman/machine/list.go Outdated Show resolved Hide resolved
podman machine list lists all virtual machines & indicates the default VM
connection, if it exists. it also can take a --format flag arg as a go
template.

[NO TESTS NEEDED]

Signed-off-by: Ashley Cui <[email protected]>
@baude
Copy link
Member

baude commented Mar 30, 2021

LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 30, 2021

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@ashley-cui
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit a373e2f into containers:master Mar 30, 2021
@ashley-cui ashley-cui deleted the machinels branch June 29, 2021 21:13
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants