-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system tests: new interactive tests #9818
Conversation
socat can create a dummy PTY that we can manipulate. This lets us run a variety of tests that we couldn't before, involving "run -it", and stty, and even "load" with no args. Signed-off-by: Ed Santiago <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice work @edsantiago |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is really cool stuff, @edsantiago !
Thank you @vrothberg ! Do you think there's a way to make it work with the shortnames prompt? I tried for a while before submitting but could never get the prompt, only the fallback. (Perhaps because stdout is a pipe - it has to be?) Anyhow, if you can think of any other tests that could benefit from this, please LMK. |
That would be fantastic. If stdout is a pipe, that may be the issue. The prompt wants stdin and stdout to be a terminal.
|
@edsantiago I just saw one of the tests flake in #9423, see https://cirrus-ci.com/task/5159880362295296?logs=main#L195 |
@Luap99 thank you. I was seeing that during development, it's a race condition that I'll need to chase and file a bug for. |
socat can create a dummy PTY that we can manipulate. This
lets us run a variety of tests that we couldn't before,
involving "run -it", and stty, and even "load" with no args.
Signed-off-by: Ed Santiago [email protected]