Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: new interactive tests #9818

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

edsantiago
Copy link
Member

socat can create a dummy PTY that we can manipulate. This
lets us run a variety of tests that we couldn't before,
involving "run -it", and stty, and even "load" with no args.

Signed-off-by: Ed Santiago [email protected]

socat can create a dummy PTY that we can manipulate. This
lets us run a variety of tests that we couldn't before,
involving "run -it", and stty, and even "load" with no args.

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 25, 2021

Nice work @edsantiago
LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 029659a into containers:master Mar 25, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is really cool stuff, @edsantiago !

@edsantiago
Copy link
Member Author

Thank you @vrothberg ! Do you think there's a way to make it work with the shortnames prompt? I tried for a while before submitting but could never get the prompt, only the fallback. (Perhaps because stdout is a pipe - it has to be?) Anyhow, if you can think of any other tests that could benefit from this, please LMK.

@vrothberg
Copy link
Member

Do you think there's a way to make it work with the shortnames prompt? I tried for a while before submitting but could never get the prompt, only the fallback. (Perhaps because stdout is a pipe - it has to be?)

That would be fantastic. If stdout is a pipe, that may be the issue. The prompt wants stdin and stdout to be a terminal.

Anyhow, if you can think of any other tests that could benefit from this, please LMK.

podman login could be a good candidate. It may prompt for user/pw.

@Luap99
Copy link
Member

Luap99 commented Mar 26, 2021

@edsantiago I just saw one of the tests flake in #9423, see https://cirrus-ci.com/task/5159880362295296?logs=main#L195

@edsantiago
Copy link
Member Author

@Luap99 thank you. I was seeing that during development, it's a race condition that I'll need to chase and file a bug for.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants