CI: update to F34: pass enforced short-name mode #9800
Conversation
Signed-off-by: Chris Evich <[email protected]>
Also, revert 4875a8f Signed-off-by: Chris Evich <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
vrothberg
force-pushed
the
shortname-farts
branch
from
1dd7a5c to
8a4be83
Compare
|
Looks like you included a whole bunch of PRs with this? |
That's intentional (see commit message): it's a continuation of the PR to run F34. |
|
Oh, more things were pulled in. Those commits are in master already. Will do an exact rebase with the next push. |
In contrast to `assert.NoError`, `require.NoError` treats mismatches fatally which in many cases is necessary to prevent subsequent checks from segfaulting. Signed-off-by: Valentin Rothberg <[email protected]>
Defer cleaning up the test artifacts as early as possible. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
shortname-farts
branch
2 times, most recently
from
cb66978 to
73ba8e7
Compare
|
@vrothberg I appreciate your help here, and word-of-warning: There are likely to be many more stumbling tests past this one. Since F34 just started official beta, I'll also likely be rolling freshly built images into #9554. Including my commits here is fine for testing, but come merge-time I would suggest not including them. I'll pick them up by rebase in #9554 eventually. |
|
@cevich, agreed. I'll continue here trying to get the unit tests to pass. Guess we need to go step by step. |
vrothberg
force-pushed
the
shortname-farts
branch
3 times, most recently
from
0a99e7f to
d89db34
Compare
Since some unit tests use "busybox", we need to point it to some alias if we want it to pass CI on F34 where we're running in enforced mode. Furthermore, make sure that the registries.conf can actually be overridden in the code. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
shortname-farts
branch
from
d89db34 to
a0f6bf6
Compare
github-actions
bot
added
the
locked - please file new issue/PR
Continuation of #9554 to help move things forward.