Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated schema:resource to schema:network to comply with JSON API #9791

Closed
wants to merge 6 commits into from

Conversation

kellen-dunham
Copy link
Contributor

The libpod JSON API handler for play kube was not decoding the URL query parameters correctly as per the API spec. Changing "reference" to "network" fixed the issue.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kellen-dunham
To complete the pull request process, please assign rhatdan after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kellen Dunham <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Mar 23, 2021

Sadly you need to squash these together, and we need a test added.

@rhatdan
Copy link
Member

rhatdan commented Mar 23, 2021

@kellen-dunham Thanks, change LGTM, but need to get it past tests.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Mar 24, 2021

Change LGTM
@kellen-dunham I don't think you signed your commit which our CI system requires. Can you please do a git commit --amend -s, fetch, rebase and push?

@kellen-dunham kellen-dunham deleted the fix_9698 branch March 30, 2021 11:31
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants