-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated schema:resource to schema:network to comply with JSON API #9791
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kellen-dunham The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kellen Dunham <[email protected]>
Sadly you need to squash these together, and we need a test added. |
@kellen-dunham Thanks, change LGTM, but need to get it past tests. |
Change LGTM |
Signed-off-by: Kellen Dunham <[email protected]> Added DCO Signed-off-by: Kellen Dunham <[email protected]>
Signed-off-by: Kellen Dunham <[email protected]>
The libpod JSON API handler for play kube was not decoding the URL query parameters correctly as per the API spec. Changing "reference" to "network" fixed the issue.