fix: build endpoint for compat API #9790
Conversation
|
@matejvasek: GitHub didn't allow me to request PR reviews from the following users: riyad. Note that only containers members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matej Vasek <[email protected]>
matejvasek
force-pushed
the
fix-isolation-serde
branch
from
8f5eb38 to
aba3bbd
Compare
Signed-off-by: Matej Vasek <[email protected]>
matejvasek
force-pushed
the
fix-isolation-serde
branch
from
5fc16bb to
4db4c65
Compare
|
/cc @mheon |
|
I have a similar PR, but have not been able to get back to this. Some of this code is in the master branch of Buildah, now I believe. |
| @@ -205,9 +205,15 @@ func BuildImage(w http.ResponseWriter, r *http.Request) { | |||
| isolation := buildah.IsolationDefault | |||
| */ | |||
| if utils.IsLibpodRequest(r) { | |||
| // isolation = buildah.Isolation(query.Isolation) | |||
| // isolation = parseLibPodIsolation(query.Isolation) | |||
There was a problem hiding this comment.
is this comment of any value?
There was a problem hiding this comment.
If I understand it correctly the comment should be removed at some point see TODO above.
There was a problem hiding this comment.
Yes I have a PR that is attempting to remove it.
I think we just merge this and I will continue to rework my PRs
|
Changes LGTM, but I'm not sure if we should go with this or @rhatdan's WIP? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
resolves: #9290
Signed-off-by: Matej Vasek [email protected]