Unification of label and until filters across list/prune endpoints #9785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/cleanup
jmguzik
force-pushed
the
unification-of-label-filter
branch
2 times, most recently
from
da7fa50 to
c4463e4
Compare
Luap99
reviewed
Mar 23, 2021
jmguzik
force-pushed
the
unification-of-label-filter
branch
3 times, most recently
from
de88217 to
f09d2f7
Compare
jmguzik
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Jakub Guzik <[email protected]>
jmguzik
force-pushed
the
unification-of-label-filter
branch
from
f09d2f7 to
f36ff14
Compare
jmguzik
changed the title
|
I decided to add also until filter to this PR as a separate commit. |
Signed-off-by: Jakub Guzik <[email protected]>
jmguzik
force-pushed
the
unification-of-label-filter
branch
from
f36ff14 to
914218c
Compare
|
Nice cleanup, thanks @jmguzik |
Luap99
approved these changes
Mar 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All label and until filters are using a similar match function. This PR unifies them and adds UT.
/kind cleanup