Support multi doc yaml for generate/play kube #9759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoVega
force-pushed
the
9129-multi-docs-kube
branch
2 times, most recently
from
ee077f9 to
5f786be
Compare
|
should also handle the configmap and volumes |
|
@zhangguanzhang I can add configmaps. For volumes (k8s persistent volume claims) I think there is some work in progress for that. I can track all the issues/prs that are related to it and check their status because that should be a dependency for this change. |
|
Nice work @EduardoVega LGTM |
|
@containers/podman-maintainers PTAL |
vrothberg
reviewed
Mar 25, 2021
Signed-off-by: Eduardo Vega <[email protected]>
EduardoVega
force-pushed
the
9129-multi-docs-kube
branch
from
5f786be to
cbf53c1
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EduardoVega, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #9129
This PR adds the following for podman play / generate kube
Signed-off-by: Eduardo Vega [email protected]