-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/containers/storage from 1.25.0 to 1.28.0 #9734
Bump github.com/containers/storage from 1.25.0 to 1.28.0 #9734
Conversation
👋 If you need additional help with Dependabot, please fill out GitHub's Support form and your request will be routed to the right team at GitHub. Be sure to include the details of any troubleshooting steps you've tried so far. |
8acf5c9
to
eb1fa32
Compare
eb1fa32
to
1c6a41a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect | ||
github.com/onsi/ginkgo v1.15.1 | ||
github.com/onsi/gomega v1.11.0 | ||
github.com/opencontainers/go-digest v1.0.0 | ||
github.com/opencontainers/image-spec v1.0.2-0.20190823105129-775207bd45b6 | ||
github.com/opencontainers/runc v1.0.0-rc91.0.20200708210054-ce54a9d4d79b | ||
github.com/opencontainers/runtime-spec v1.0.3-0.20200817204227-f9c09b4ea1df | ||
github.com/opencontainers/runc v1.0.0-rc93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bump is still barking, see #9738
1c6a41a
to
2cd01c6
Compare
Restarted what I hope is a flake, a horrible long long list of failures. This PR is important to me because it should fix one of the longstanding failures in podman gating tests on rawhide. |
This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a |
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.25.0 to 1.28.0. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](containers/storage@v1.25.0...v1.28.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Signed-off-by: Giuseppe Scrivano <[email protected]>
pushed another version. I think the correct fix requires containers/common#481 and it will make podman-in-a-container future proof when the outer runtime doesn't know about newer capabilities for now let's just block upgrading |
2cd01c6
to
ec1651f
Compare
@edsantiago @vrothberg PTAL tests are green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a bit worried
k8s.io/apimachinery v0.20.4 | ||
) | ||
|
||
replace github.com/syndtr/gocapability => github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this fixes the in container
testing, right?
I'm a bit afraid of this trick since it's not sustainable on the long run. Downstream packages like Debian will have troubles, and we don't get updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opencontainers/runc@6dfbe9b is part of runc rc93. What is the reason to still pin this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's causing issues in the in-container tests. @giuseppe is about to create a separate PR with the new c/common release to address these.
It's a temporary fix to unblock bumping c/storage et al.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed with #9762
@saschagrunert, can you merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot-preview[bot], saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps github.com/containers/storage from 1.25.0 to 1.28.0.
Release notes
Sourced from github.com/containers/storage's releases.
... (truncated)
Commits
d188375
Bump to v1.28.01b9e7e3
Merge pull request #855 from giuseppe/copy-create-socket-not-a-fifo029896b
copy: create a unix socket with os.ModeSocketeb714be
Merge pull request #854 from containers/dependabot/go_modules/github.com/hash...869e3b9
build(deps): bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.13c13812
Merge pull request #851 from nalind/check-lgetxattrda8b28a
chown: ignore both pkg/system.EOPNOTSUPP and pkg/system.ErrNotSupportedPlatform7df1ede
Merge pull request #850 from containers/dependabot/go_modules/github.com/siru...795951f
build(deps): bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1e86e042
Merge pull request #849 from giuseppe/prepare-zstd-chunkedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: