Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containers/storage from 1.25.0 to 1.28.0 #9734

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps github.com/containers/storage from 1.25.0 to 1.28.0.

Release notes

Sourced from github.com/containers/storage's releases.

v1.28.0

Add dependabot.yml configuration file
Add more mount information to errors
Inherit system storage driver in rootless configurations
archive: make getFileOwner public
archive: make getWhiteoutConverter public
archive: whiteout creation with a handler
build(deps): bump github.com/Microsoft/hcsshim from 0.8.14 to 0.8.15
build(deps): bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
build(deps): bump github.com/klauspost/compress from 1.11.7 to 1.11.12
build(deps): bump github.com/moby/sys/mountinfo from 0.4.0 to 0.4.1
build(deps): bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1
chown: ignore both pkg/system.EOPNOTSUPP and pkg/system.ErrNotSupportedPlatform
containers-storage: add --volatile to container create
copy: create a unix socket with os.ModeSocket
drivers: make copyRegular public
drivers: new function CopyRegularToFile
fswriters: honor nosync option
overlay: add detection for overlay support in a user namespace
overlay: allow to reset mount_program
overlay: factor function out
overlay: fix path to incompat/volatile
overlay: improve overlay error message
overlay: public function to check for overlay support
overlay: record if using mount_program
overlay: rootless move error to debug message
overlay: use direct mount instead of mountFrom
support patches to prepare [#775](https://github.com/containers/storage/issues/775)
tests: test mount/unmount volatile container
types: check for native overlay support

v1.27.0

Move storageOpts structures into types subdir to shrink bindings.
(*store).Diff: add missing unlock in error case
pkg/lockfile: fix a race and re-enable unit tests
Add warning about possible storage corruption
pkg/chrootarchive.TestChrootUntarWithHugeExcludesList: fix compile error
pkg/archive.TestCopyWithTarSrcFile(): update for NoOverwriteDirNonDir
drivers/devmapper: default the rootfs directory to 0555
TestRootlessRuntimeDir: iterate tests using testing.T.Run()
Fix TestDefaultStoreOpts()
getRootlessRuntimeDirIsolated(): don't use an empty tmpPerUserDir
drivers/zfs: default the base layer to 0555
drivers/btrfs: default the base layer to 0555
drivers/aufs: inherit permissions on "/" from parent layers
drivers/vfs: inherit permissions on "/" from parent layers
graphtest: expect 0555 permissions
pkg/archive.parseDirent(): adjust to avoid unsafe pointer conversion
Add warning about possible storage corruption
pkg/idtools.TestParseSubidFileWithNewlinesAndComments(): clean up

... (truncated)

Commits
  • d188375 Bump to v1.28.0
  • 1b9e7e3 Merge pull request #855 from giuseppe/copy-create-socket-not-a-fifo
  • 029896b copy: create a unix socket with os.ModeSocket
  • eb714be Merge pull request #854 from containers/dependabot/go_modules/github.com/hash...
  • 869e3b9 build(deps): bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
  • 3c13812 Merge pull request #851 from nalind/check-lgetxattr
  • da8b28a chown: ignore both pkg/system.EOPNOTSUPP and pkg/system.ErrNotSupportedPlatform
  • 7df1ede Merge pull request #850 from containers/dependabot/go_modules/github.com/siru...
  • 795951f build(deps): bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1
  • e86e042 Merge pull request #849 from giuseppe/prepare-zstd-chunked
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Mar 17, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2021
@dependabot-preview
Copy link
Contributor Author

👋 If you need additional help with Dependabot, please fill out GitHub's Support form and your request will be routed to the right team at GitHub.

Be sure to include the details of any troubleshooting steps you've tried so far.

@giuseppe giuseppe force-pushed the dependabot/go_modules/github.com/containers/storage-1.28.0 branch from 8acf5c9 to eb1fa32 Compare March 17, 2021 13:45
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2021
@giuseppe giuseppe force-pushed the dependabot/go_modules/github.com/containers/storage-1.28.0 branch from eb1fa32 to 1c6a41a Compare March 18, 2021 12:55
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
github.com/onsi/ginkgo v1.15.1
github.com/onsi/gomega v1.11.0
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.0.2-0.20190823105129-775207bd45b6
github.com/opencontainers/runc v1.0.0-rc91.0.20200708210054-ce54a9d4d79b
github.com/opencontainers/runtime-spec v1.0.3-0.20200817204227-f9c09b4ea1df
github.com/opencontainers/runc v1.0.0-rc93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bump is still barking, see #9738

@giuseppe giuseppe force-pushed the dependabot/go_modules/github.com/containers/storage-1.28.0 branch from 1c6a41a to 2cd01c6 Compare March 18, 2021 13:58
@edsantiago
Copy link
Member

Restarted what I hope is a flake, a horrible long long list of failures. This PR is important to me because it should fix one of the longstanding failures in podman gating tests on rawhide.

@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

@giuseppe
Copy link
Member

pushed another version.

I think the correct fix requires containers/common#481 and it will make podman-in-a-container future proof when the outer runtime doesn't know about newer capabilities

for now let's just block upgrading github.com/syndtr/gocapability

@giuseppe giuseppe force-pushed the dependabot/go_modules/github.com/containers/storage-1.28.0 branch from 2cd01c6 to ec1651f Compare March 18, 2021 19:32
@giuseppe
Copy link
Member

@edsantiago @vrothberg PTAL tests are green now

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a bit worried

k8s.io/apimachinery v0.20.4
)

replace github.com/syndtr/gocapability => github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this fixes the in container testing, right?

I'm a bit afraid of this trick since it's not sustainable on the long run. Downstream packages like Debian will have troubles, and we don't get updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opencontainers/runc@6dfbe9b is part of runc rc93. What is the reason to still pin this dependency?

Copy link
Member

@vrothberg vrothberg Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's causing issues in the in-container tests. @giuseppe is about to create a separate PR with the new c/common release to address these.

It's a temporary fix to unblock bumping c/storage et al.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with #9762

@vrothberg
Copy link
Member

@saschagrunert, can you merge?

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot-preview[bot], saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit c4a5513 into master Mar 19, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/github.com/containers/storage-1.28.0 branch March 19, 2021 10:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants