[v3.0.1-rhel] podman cp: ignore EPERMs in rootless mode #9732
Conversation
Signed-off-by: Valentin Rothberg <[email protected]>
Ignore permission errors when copying from a rootless container. TTY devices inside rootless containers are owned by the host's root user which is "nobody" inside the container's user namespace rendering us unable to even read them. Enable the integration test which was temporarily disabled for rootless users. Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Had to add a third commit to fix the containers.conf timezone e2e test. I do not know why that worked before since New York yields EDT, not EST. |
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd // indirect | |||
| github.com/containernetworking/cni v0.8.1 | |||
| github.com/containernetworking/plugins v0.9.0 | |||
| github.com/containers/buildah v1.19.7 | |||
There was a problem hiding this comment.
This will give us a higher version of Buildah vendored into Podman than we have available on RHEL (v1.19.6).
There was a problem hiding this comment.
Not sure what that implies. We need .7 to fix the issue.
There was a problem hiding this comment.
Just concerned that if you run Buildah you could get different behavior than running podman build. I'm probably over-fretting.
test/e2e/containers_conf_test.go
Outdated
| @@ -311,7 +311,7 @@ var _ = Describe("Podman run", func() { | |||
| session = podmanTest.Podman([]string{"run", ALPINE, "date", "+'%H %Z'"}) | |||
| session.WaitWithDefaultTimeout() | |||
| Expect(session.ExitCode()).To(Equal(0)) | |||
| Expect(session.OutputToString()).To(ContainSubstring("EST")) | |||
| Expect(session.OutputToString()).To(ContainSubstring("EDT")) | |||
There was a problem hiding this comment.
Won't this change/fail in the fall when we go back to EST? Seems like a check that needs to be modified....
There was a problem hiding this comment.
DO NOT MERGE THIS. Use 8de5607 instead.
The New York timezone changes between summer and winter time. Make sure the test allows both timezones. Signed-off-by: Paul Holzinger <[email protected]>
vrothberg
force-pushed
the
v3.0.1-rhel-cp-backports
branch
from
dc90ab4 to
82c35bf
Compare
|
I can live with Buildah patch release not matching. If it was a minor release I'd be more concerned. LGTM, but CI is red even after your patch. |
The APIv2 tests flake. I want to wait with restarting until the other tests turn green. |
|
Maybe this would be a good time to cherry-pick #9699 |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Ignore permission errors when copying from a rootless container.
TTY devices inside rootless containers are owned by the host's
root user which is "nobody" inside the container's user namespace
rendering us unable to even read them.
Enable the integration test which was temporarily disabled for rootless
users.
Signed-off-by: Valentin Rothberg [email protected]
This one slipped through in the backports. Last bit needed to fix https://bugzilla.redhat.com/show_bug.cgi?id=1936927.