Network prune filters for http api (compat and libpod) #9710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
jmguzik
changed the title
jmguzik
commented
Mar 14, 2021
jmguzik
force-pushed
the
network-prune-filters-http-api
branch
2 times, most recently
from
0377f73 to
b76e051
Compare
|
It seems there is a timezone issue (maybe due to a time change in the USA): |
Luap99
pushed a commit
to Luap99/libpod
that referenced
this pull request
Mar 15, 2021
The `libpod/network` package should only be used on the backend and not the client. The client used this package only for two functions so move them into a new `pkg/network` package. This is needed so we can put linux only code into `libpod/network`, see containers#9710. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]>
Luap99
pushed a commit
to Luap99/libpod
that referenced
this pull request
Mar 15, 2021
Some packages used by the remote client imported the libpod package. This is not wanted because it adds unnecessary bloat to the client and also causes problems with platform specific code(linux only), see containers#9710. The solution is to move the used functions/variables into extra packages which do not import libpod. This change shrinks the remote client size more than 6MB compared to the current master. [NO TESTS NEEDED] I have no idea how to test this properly but with containers#9710 the cross compile should fail. Signed-off-by: Paul Holzinger <[email protected]>
jmguzik
force-pushed
the
network-prune-filters-http-api
branch
3 times, most recently
from
0828547 to
b3d03d0
Compare
jmguzik
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
sys remote ubuntu-2004 root host fails because of some podman build issues. I think it is unrelated. I would be grateful if somebody with rights could re-run. |
Luap99
reviewed
Mar 16, 2021
Signed-off-by: Jakub Guzik <[email protected]>
jmguzik
force-pushed
the
network-prune-filters-http-api
branch
from
b3d03d0 to
8ea02d0
Compare
Commits squashed and API docs updated. |
openshift-ci-robot
added
the
approved
|
@containers/podman-maintainers PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
Prune filters are missing not implemented in HTTP API. This PR tackles the topic in compat and libpod API.