Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add restart-policy to container filters & --filter to podman start #9689

Merged
merged 1 commit into from
May 6, 2021
Merged

add restart-policy to container filters & --filter to podman start #9689

merged 1 commit into from
May 6, 2021

Conversation

boaz0
Copy link
Collaborator

@boaz0 boaz0 commented Mar 10, 2021 •
edited
Loading

This patch adds two things:

  1. restart-policy to the container filters - you can filter containers by their restart policy
  2. --filter to the podman start command - you can filter what containers to start

by adding these two you can start only containers that has a restart-policy of "on-failure" for example.

//cc @rhatdan @vrothberg

related #8779

@boaz0 boaz0 mentioned this pull request Mar 10, 2021
Merged
6 tasks
rhatdan
rhatdan approved these changes Mar 10, 2021
View reviewed changes
cmd/podman/containers/start.go Show resolved Hide resolved
cmd/podman/containers/start.go Outdated Show resolved Hide resolved
cmd/podman/containers/start.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: boaz0, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@TomSweeneyRedHat
Copy link
Member

All kinds of test unhappiness @boaz0

@boaz0
Copy link
Collaborator Author

boaz0 commented Mar 15, 2021

Yeah, that's odd. I will look at this today. Thanks.

edsantiago
edsantiago reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Thanks for this work!

test/system/710-start.bats Outdated Show resolved Hide resolved
test/system/710-start.bats Outdated Show resolved Hide resolved
test/system/710-start.bats Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 15, 2021
@boaz0
Copy link
Collaborator Author

boaz0 commented Mar 25, 2021

ping @TomSweeneyRedHat I am not sure the CI failure is related to my changes.

@rhatdan
Copy link
Member

rhatdan commented May 6, 2021

@boaz0 Please rebase, I would love to get this in before we release podman 3.2

@boaz0
Copy link
Collaborator Author

boaz0 commented May 6, 2021

No problem! @rhatdan

@TomSweeneyRedHat
Copy link
Member

LGTM
And

Happy green test buttons!

@rhatdan
Copy link
Member

rhatdan commented May 6, 2021

Great job @boaz0 Thanks

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 034470e into containers:master May 6, 2021
@boaz0 boaz0 deleted the boaz-1 branch May 7, 2021 06:06
@boaz0
Copy link
Collaborator Author

boaz0 commented May 7, 2021

This is me right now:

Thank you so much guys!!! I couldn't have done it without your help and support.

@edsantiago edsantiago mentioned this pull request May 10, 2021
Closed
@boaz0 boaz0 mentioned this pull request Jun 7, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan approved these changes

@edsantiago edsantiago edsantiago left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@boaz0 @openshift-ci-robot @TomSweeneyRedHat @rhatdan @edsantiago @openshift-merge-robot