[CI:DOCS] Add docs about how to access APIs inside containers #9678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @umohnani8 |
rhatdan
reviewed
Mar 9, 2021
| @@ -13,6 +13,10 @@ If no endpoint is provided, defaults will be used. The default endpoint for a r | |||
| service is *unix:/run/podman/podman.sock* and rootless is *unix:/$XDG_RUNTIME_DIR/podman/podman.sock* (for | |||
| example *unix:/run/user/1000/podman/podman.sock*) | |||
|
|
|||
| To access the API service inside a container, you need to | |||
| - mount the socket as a volume | |||
| - run the container with `--privileged` | |||
There was a problem hiding this comment.
This is is not necessary.
--security-opt label:disable ...
Should be enough.
| @@ -13,6 +13,10 @@ If no endpoint is provided, defaults will be used. The default endpoint for a r | |||
| service is *unix:/run/podman/podman.sock* and rootless is *unix:/$XDG_RUNTIME_DIR/podman/podman.sock* (for | |||
| example *unix:/run/user/1000/podman/podman.sock*) | |||
|
|
|||
| To access the API service inside a container, you need to | |||
There was a problem hiding this comment.
We try to avoid using pronouns, especially "you" in the man pages.
Suggested change
| To access the API service inside a container, you need to | |
| To access the API service inside a container: |
Signed-off-by: xcffl <[email protected]>
cognition9144
force-pushed
the
doc-sock-in-container-privileged
branch
from
ae6336b to
dc0c72a
Compare
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, xcffl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially the
--privilegedflag which is hard to guess as a requirement