options: append CLI graph driver options #9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
giuseppe
force-pushed
the
cli-overrides-conf
branch
from
469f67e to
9ca3e02
Compare
if --storage-opt are specified on the CLI append them after what is specified in the configuration files instead of overriding it. Closes: containers#9657 [NO TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
cli-overrides-conf
branch
from
9ca3e02 to
6d48997
Compare
|
LGTM |
|
What happens if I want to override one? |
|
LGTM if @rhatdan is hip with the "how to override" answer. |
We append the CLI values after the ones from the configuration files, so whatever you specify on the CLI will override the old value coming from the configuration files. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if --storage-opt are specified on the CLI append them after what is
specified in the configuration files instead of overriding it.
Closes: #9657
[NO TESTS NEEDED]
Signed-off-by: Giuseppe Scrivano [email protected]