Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] Bump pre-commit-hooks version #9627

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Mar 5, 2021

Signed-off-by: xatier [email protected]

Tested locally, this shouldn't introduce any regressions.

$ pre-commit run -av
Fix End of Files.........................................................Passed
- hook id: end-of-file-fixer
- duration: 0.08s
Trim Trailing Whitespace.................................................Passed
- hook id: trailing-whitespace
- duration: 0.09s
Mixed line ending........................................................Passed
- hook id: mixed-line-ending
- duration: 0.07s
check BOM - deprecated: use fix-byte-order-marker........................Passed
- hook id: check-byte-order-marker
- duration: 0.08s
Check that executables have shebangs.....................................Passed
- hook id: check-executables-have-shebangs
- duration: 0.06s
Check for merge conflicts................................................Passed
- hook id: check-merge-conflict
- duration: 0.07s

@giuseppe
Copy link
Member

giuseppe commented Mar 5, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, xatier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@giuseppe
Copy link
Member

giuseppe commented Mar 5, 2021

/ok-to-test

@rhatdan rhatdan changed the title Bump pre-commit-hooks version [NO TESTS NEEDED] Bump pre-commit-hooks version Mar 5, 2021
@mheon
Copy link
Member

mheon commented Mar 5, 2021

I think you need to make a change to the PR (even resetting the commit time would be sufficient) and force-push to convince the Validate task to succeed.

@xatier
Copy link
Contributor Author

xatier commented Mar 6, 2021

@rhatdan , @mheon , it seems like git commit --amend && git push -f is not enough, should I also edit the commit message title as well?

@rhatdan
Copy link
Member

rhatdan commented Mar 7, 2021

LGTM

@mheon
Copy link
Member

mheon commented Mar 8, 2021

Merging.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit b386d23 into containers:master Mar 8, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants