Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor python tests to run against python3.9 #9556

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Mar 1, 2021

  • Introduce sub-package compat to meet packaging and import requirements
  • Update documenation for running tests
  • Add requirements.txt to improve IDE support

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Mar 1, 2021
@jwhonce jwhonce requested a review from baude March 1, 2021 18:00
@jwhonce jwhonce self-assigned this Mar 1, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2021

LGTM

* Introduce sub-package compat to meet packaging and import requirements
* Update documenation for running tests
* Add requirements.txt to improve IDE support

Signed-off-by: Jhon Honce <[email protected]>
@baude
Copy link
Member

baude commented Mar 1, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@baude
Copy link
Member

baude commented Mar 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@baude
Copy link
Member

baude commented Mar 1, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8af6680 into containers:master Mar 1, 2021
@edsantiago
Copy link
Member

Timing comparison:

type distro user local remote container
int fedora-33 root 33:54 39:55 31:38
int ubuntu-2004 root 44:44 01:10:12
int ubuntu-2010 root 41:04 46:28
int fedora-33 rootless 34:26
sys fedora-33 root 18:33 13:09
sys ubuntu-2004 root 25:24 32:09
sys ubuntu-2010 root 24:38 18:13
sys fedora-33 rootless 15:56

@edsantiago
Copy link
Member

edsantiago commented Mar 2, 2021

I extended my timing-compare script to handle system tests. Results for podman-remote tests are interesting. Boldface indicates a number that is more than 50% off from a different result. Only results over 5 seconds are listed, anything less than that is ignored. @baude @vrothberg PTAL

fedora
33
ubuntu
2004
ubuntu
2010
20 podman run - basic tests 3.00 5.00 5.00
33 podman run --log-driver 4.00 9.00 5.00
48 podman ps --filter 2.00 7.00 4.00
51 podman stop --all 5.00 9.00 6.00
53 podman stop - can trap signal 5.00 9.00 6.00
65 podman cp file from host to container 19.00 76.00 26.00
66 podman cp file from container to host 15.00 95.00 25.00
67 podman cp dir from host to container 17.00 142.00 35.00
68 podman cp dir from container to host 14.00 107.00 28.00
69 podman cp file from host to container volume 1.00 34.00 6.00
70 podman cp file from host to container mount 2.00 29.00 6.00
71 podman cp * - wildcard copy multiple files from container to host 1.00 18.00 5.00
72 podman cp - will not recognize symlink pointing into host space 1.00 14.00 5.00
73 podman cp - will not expand globs in host space (#3829) 1.00 13.00 4.00
74 podman cp - will not expand wildcard 1.00 13.00 5.00
75 podman cp into container: weird symlink expansion 3.00 28.00 13.00
76 podman cp into a subdirectory matching GraphRoot 3.00 22.00 8.00
77 podman cp from stdin to container 13.00 41.00 24.00
78 podman cp from container to stdout 12.00 38.00 21.00
79 podman build - basic test 5.00 35.00 15.00
82 podman build - cache (#3920) 4.00 24.00 11.00
83 podman build - URLs 2.00 15.00 6.00
84 podman build - workdir, cmd, env, label 17.00 129.00 58.00
85 podman build - stdin test 4.00 17.00 14.00
86 podman build - does not gobble stdin that does not belong to it 2.00 7.00 7.00
87 podman build --layers test 6.00 13.00 16.00
88 build with copy-from referencing the base image 12.00 18.00 21.00
99 podman load - by image ID 2.00 5.00 6.00
100 podman load - by image name 3.00 6.00 6.00
102 podman load - multi-image archive 4.00 8.00 7.00
103 podman load - multi-image archive with redirect 4.00 8.00 7.00
105 podman kill - rejects invalid args 2.00 6.00 6.00
120 podman volume: exec/noexec 2.00 5.00 5.00
121 podman volume, implicit creation with run 4.00 7.00 6.00
123 podman volume prune 3.00 7.00 6.00
125 podman pod - communicating between pods 3.00 8.00 7.00
126 podman pod - communicating via /dev/shm 2.00 6.00 6.00
135 podman system df - with active containers and volumes 3.00 5.00 5.00
153 podman shell completion test 65.00 201.00 142.00

@jwhonce jwhonce deleted the wip/docker branch June 30, 2021 16:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants