Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] swagger: removes the schema type for PodSpecGenerator $ref #9505

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

TristanCacqueray
Copy link
Contributor

No description provided.

@mheon
Copy link
Member

mheon commented Feb 24, 2021

@TristanCacqueray Recommend adding [CI:DOCS] to your title, adding a signoff to the commit, and force-pushing to fix CI.

Otherwise LGTM.
/approve
@baude @jwhonce PTAL

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@TristanCacqueray TristanCacqueray changed the title swagger: removes the schema type for PodSpecGenerator $ref [CI:DOCS] swagger: removes the schema type for PodSpecGenerator $ref Feb 24, 2021
When using a $ref, the type is ignored and it can confuse the openapi codegen
and make it fails with this error:

  attribute paths.'/libpod/pods/create'(post).[create].type is unexpected

This change removes the schema type attribute.

Signed-off-by: Tristan Cacqueray <[email protected]>
@TristanCacqueray
Copy link
Contributor Author

@mheon thank you for the feedback.

@TomSweeneyRedHat
Copy link
Member

Still fighting fedora-33 test, IDK if that's an issue with the test system or not.

@mheon
Copy link
Member

mheon commented Feb 24, 2021

That looks network-related. Restarted it.

@rhatdan
Copy link
Member

rhatdan commented Feb 26, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, rhatdan, TristanCacqueray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 05410e8 into containers:master Feb 26, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants