Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns search domains from cni response to resolv.conf #9501

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Feb 24, 2021

This fixes slow local host name lookups.
see containers/dnsname#57

This fixes slow local host name lookups.
see containers/dnsname#57

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

@Luap99 do you have numbers regarding the performance improvements?

@Luap99
Copy link
Member Author

Luap99 commented Feb 24, 2021

@vrothberg

$ sudo bin/podman run --network cni-podman3 --name test --replace alpine time nslookup test
c0b65c64d56331e62bb0c8e86a1f53c3b6e4ce5932dfe0267e59f7f727b55cc0
Server:         10.89.2.1
Address:        10.89.2.1:53

Name:   test
Address: 10.89.2.8

real    0m 0.12s
user    0m 0.00s
sys     0m 0.00s
$ sudo bin/podman run --network cni-podman3 --dns-search dns.podman  --name test --replace alpine time nslookup test
59e759d47947eed1cf31d46f0e0295829c2632f54dcd11ece8ec03481afbe50b
Server:         10.89.2.1
Address:        10.89.2.1:53

Name:   test.dns.podman
Address: 10.89.2.9

Non-authoritative answer:
real    0m 0.00s
user    0m 0.00s
sys     0m 0.00s

You can test by adding --dns-search dns.podman. also see containers/dnsname#55

@Luap99
Copy link
Member Author

Luap99 commented Feb 24, 2021

@vrothberg It is not really consistent sometime it is also fast without the search domain. I also believe this is the reason why dnsname test failed in my rootless network PR and only worked after adding dns.podman

@Luap99
Copy link
Member Author

Luap99 commented Feb 24, 2021

It also looks like it was needed for ubuntu #9385

@rhatdan
Copy link
Member

rhatdan commented Feb 24, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4846f87 into containers:master Feb 24, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99 Luap99 deleted the dns-search-cni branch February 24, 2021 14:37
@developedsoftware
Copy link

What version of podman was this released under?

@Luap99
Copy link
Member Author

Luap99 commented Jan 20, 2022

v3.1
If you click on the commit you can see the tags where this commit is included

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants