-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dns search domains from cni response to resolv.conf #9501
Add dns search domains from cni response to resolv.conf #9501
Conversation
This fixes slow local host name lookups. see containers/dnsname#57 Signed-off-by: Paul Holzinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Luap99 do you have numbers regarding the performance improvements? |
You can test by adding |
@vrothberg It is not really consistent sometime it is also fast without the search domain. I also believe this is the reason why dnsname test failed in my rootless network PR and only worked after adding dns.podman |
It also looks like it was needed for ubuntu #9385 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What version of podman was this released under? |
v3.1 |
This fixes slow local host name lookups.
see containers/dnsname#57