Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO TESTS NEEDED] Replace Labels and Options nulls with {} in NetworkResource #9480

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[NO TESTS NEEDED] Replace Labels and Options nulls with {} in NetworkResource #9480

merged 1 commit into from
Feb 23, 2021

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented Feb 22, 2021 •
edited
Loading

Fixes #9466
Closes #9466

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2021
@jmguzik jmguzik changed the title Replace Labels and Options nulls with {} in NetworkResource [WIP] Replace Labels and Options nulls with {} in NetworkResource Feb 22, 2021
@mheon
Copy link
Member

mheon commented Feb 22, 2021

LGTM

@mheon
Copy link
Member

mheon commented Feb 22, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@jmguzik
Copy link
Contributor Author

jmguzik commented Feb 22, 2021 •
edited
Loading

@mheon We do not test this?

@jmguzik jmguzik changed the title [WIP] Replace Labels and Options nulls with {} in NetworkResource [NO TESTS NEEDED] [WIP] Replace Labels and Options nulls with {} in NetworkResource Feb 22, 2021
@jmguzik jmguzik force-pushed the replace-nil-with-braces-network-resource branch from 2e4ab51 to fcf669f Compare February 22, 2021 23:31
@jmguzik jmguzik changed the title [NO TESTS NEEDED] [WIP] Replace Labels and Options nulls with {} in NetworkResource [NO TESTS NEEDED] Replace Labels and Options nulls with {} in NetworkResource Feb 22, 2021
@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2021

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@jmguzik
Copy link
Contributor Author

jmguzik commented Feb 23, 2021

I added no tests needed just to spin ci.
Let me know if tests are needed and if yes - on which level.

@jmguzik jmguzik marked this pull request as ready for review February 23, 2021 01:12
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2021
@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 96fc9d9 into containers:master Feb 23, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCKER Compatibility bug: http://localhost/networks/[network id] returns null for Options instead of {}
5 participants
@jmguzik @mheon @openshift-ci-robot @rhatdan @openshift-merge-robot