Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.1-rhel] bump go module to v3 #9471

Conversation

vrothberg
Copy link
Member

We missed bumping the go module, so let's do it now :)

  • Automated go code with github.com/sirkon/go-imports-rename
  • Manually via vgrep podman/v2 the rest

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@mheon
Copy link
Member

mheon commented Feb 22, 2021

I'm doubtful we can justify a backport on this.

We missed bumping the go module, so let's do it now :)

* Automated go code with github.com/sirkon/go-imports-rename
* Manually via vgrep podman/v2 the rest

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg force-pushed the 3.0.1-rhel-bump-go-module branch from 2cd0dbb to 45155c0 Compare February 22, 2021 15:01
@vrothberg
Copy link
Member Author

I'm doubtful we can justify a backport on this.

@rhatdan & @TomSweeneyRedHat wanted this as a blocker. We can close the PR in case minds change.

@vrothberg
Copy link
Member Author

/hold

... until we can :)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@vrothberg
Copy link
Member Author

/hold cancel

I think we can merge. BZ: 1931545.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
@mheon
Copy link
Member

mheon commented Feb 25, 2021

Not yet - blocker is not yet approved

@TomSweeneyRedHat
Copy link
Member

Approvals are a bit delayed due to RHEL F2F meetings. I suspect we'll see a flurry of stuff on Monday. Has this been fixed upstream?

@vrothberg
Copy link
Member Author

Approvals are a bit delayed due to RHEL F2F meetings. I suspect we'll see a flurry of stuff on Monday. Has this been fixed upstream?

Yes. Both in the master branch and the v3.0 one.

@TomSweeneyRedHat
Copy link
Member

/lgtm
Approved per Josh Boyer in email

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit a413ee8 into containers:v3.0.1-rhel Feb 27, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants