-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0.1-rhel] bump go module to v3 #9471
[3.0.1-rhel] bump go module to v3 #9471
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm doubtful we can justify a backport on this. |
We missed bumping the go module, so let's do it now :) * Automated go code with github.com/sirkon/go-imports-rename * Manually via vgrep podman/v2 the rest Signed-off-by: Valentin Rothberg <[email protected]>
2cd0dbb
to
45155c0
Compare
@rhatdan & @TomSweeneyRedHat wanted this as a blocker. We can close the PR in case minds change. |
/hold ... until we can :) |
/hold cancel I think we can merge. BZ: 1931545. |
Not yet - blocker is not yet approved |
Approvals are a bit delayed due to RHEL F2F meetings. I suspect we'll see a flurry of stuff on Monday. Has this been fixed upstream? |
Yes. Both in the master branch and the v3.0 one. |
/lgtm |
We missed bumping the go module, so let's do it now :)
Signed-off-by: Valentin Rothberg [email protected]