Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] Log working dir when chdir fails #9436

Merged
merged 1 commit into from
Feb 21, 2021
Merged

[NO TESTS NEEDED] Log working dir when chdir fails #9436

merged 1 commit into from
Feb 21, 2021

Conversation

jonas-schievink
Copy link
Contributor

This provides a bit more info when chdir fails, making it easier to debug setup issues.

@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2021

LGTM
Thanks @jonas-schievink
You need to sign your commits.

git commit -a -s --amend
git push --force

@jonas-schievink
Copy link
Contributor Author

Right, fixed that

@mheon
Copy link
Member

mheon commented Feb 19, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@rhatdan rhatdan changed the title Log working dir when chdir fails [NO TESTS NEEDED] Log working dir when chdir fails Feb 19, 2021
@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2021

@jonas-schievink Could you rebase and repush. I added the no tests required flag, to allow this to get tested and merged.

Signed-off-by: Jonas Schievink <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2021

@containers/podman-maintainers PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM
F33 root test is failing, but I believe that's an issue elsewhere today.

@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonas-schievink, mheon, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4a6582b into containers:master Feb 21, 2021
@jonas-schievink jonas-schievink deleted the patch-1 branch February 21, 2021 17:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants