Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Fix typo podman run doc in flag -pid=mode "efault" #9394

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

paranlee
Copy link
Contributor

@paranlee paranlee commented Feb 16, 2021

Hello! I am Paran Lee

When I am reading the podman run doc

http://docs.podman.io/en/latest/markdown/podman-run.1.html

find typo in flag –pid=mode

"efault"

If the flag is not explicitly declared, it is created as a PID namespace.

Signed-off-by: Paran Lee [email protected]

@paranlee paranlee changed the title fix typo in flag **--pid**=*mode* "efault" Fix typo podman run doc in flag **--pid**=*mode* "efault" Feb 16, 2021
@paranlee paranlee changed the title Fix typo podman run doc in flag **--pid**=*mode* "efault" [CI:DOCS] Fix typo podman run doc in flag **--pid**=*mode* "efault" Feb 16, 2021
@paranlee paranlee changed the title [CI:DOCS] Fix typo podman run doc in flag **--pid**=*mode* "efault" Fix typo podman run doc in flag **--pid**=*mode* "efault" Feb 16, 2021
@paranlee paranlee changed the title Fix typo podman run doc in flag **--pid**=*mode* "efault" [CI:DOCS] Fix typo podman run doc in flag **--pid**=*mode* "efault" Feb 16, 2021
@paranlee paranlee changed the title [CI:DOCS] Fix typo podman run doc in flag **--pid**=*mode* "efault" [CI:DOCS] Fix typo podman run doc in flag -pid=mode "efault" Feb 16, 2021
@paranlee
Copy link
Contributor Author

/assign @zhangguanzhang

@zhangguanzhang
Copy link
Collaborator

zhangguanzhang commented Feb 16, 2021

you must signed off in your git commit message and git push -f
你的git commit信息里需要修改成个人信息的签名后再git push -f推下

Signed-off-by: zhangguanzhang <[email protected]>

另外ci还有其他问题,有个pr修复了ci的问题,你最好fetch+rebase下

@paranlee
Copy link
Contributor Author

paranlee commented Feb 16, 2021

you must signed off in your git commit message and git push -f
你的git commit信息里需要修改成个人信息的签名后再git push -f推下

Signed-off-by: zhangguanzhang <[email protected]>

另外ci还有其他问题,有个pr修复了ci的问题,你最好fetch+rebase下

Acknowledge!

I rebase on latest master branch and commit with "siged off" message

@zhangguanzhang thank you!

@rhatdan
Copy link
Member

rhatdan commented Feb 16, 2021

Thanks @paranlee
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@rhatdan rhatdan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: paranlee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8c444e6 into containers:master Feb 16, 2021
@paranlee paranlee deleted the patch-1 branch July 9, 2021 06:01
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants