Add missing early returns in compat API

[riyad]

While looking to "fix" #9314 I found a few more missing early returns.
This only fixes the double response part of #9314.

The weird thing is utils.Error() totally ignores the 2nd (i.e. apiMessage) argument which is sometimes used to add context to the error, but doesn't end up in either the logs or the response. This seems to be an oversight since its initial implementation. o.O

Closes #9314

[zhangguanzhang]

I think should not change this line

[riyad]

The idea was to make it more similar to other endpoints ... I was under the impression that the "Something went wrong.-style is the most common. But trying to prove my point I found quite some counter examples (see below). 🤷
If you still want it I can revert this.

"Something went wrong.-style examples:

• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers.go#L99
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers.go#L166
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers.go#L194
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_logs.go#L38
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_prune.go#L24
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/images_remove.go#L24
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/images_search.go#L33
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/networks.go#L221
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/networks.go#L300
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/networks.go#L340
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/networks.go#L371
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/volumes.go#L100
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/volumes.go#L277

http.StatusText(http.StatusBadRequest)-style examples:

• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers.go#L43
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_top.go#L28
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_stop.go#L31
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_restart.go#L31
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_create.go#L28
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/volumes.go#L34
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/volumes.go#L93

totally different style:

• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_start.go#L22
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_attach.go#L30
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/events.go#L87
• https://github.com/containers/podman/blob/master/pkg/api/handlers/compat/containers_archive.go#L39

[zhangguanzhang]

should signed of at the git commit messages

[vrothberg]

Changes LGTM

To pass CI, the commit must be signed: git commit -s --amend and repush

[rhatdan]

You also need to add

[NO TESTS NEEDED]

To this commit, otherwise you will need to add tests.

LGTM

[rhatdan]

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, riyad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

/hold
CI doesn't seem to have run
@cevich PTAL

[riyad]

I'm not sure what new changes the bot has detected. 😅 I just rebased the PR to re-trigger the CI.

[rhatdan]

/lgtm

[zhangguanzhang]

/hold cancel

[cevich]

CI doesn't seem to have run

Hmmm, yeah, I see it's not just Cirrus-CI but nothing ran for fa9429a9474ff8190b7a8686f43b5ba0ce9392c2 Most likely this was a Github problem and not a Cirrus-CI problem. I'll keep on the lookout for this happening again.