Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Update swagger doc for libpod container wait #9339

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[CI:DOCS] Update swagger doc for libpod container wait #9339

merged 1 commit into from
Feb 19, 2021

Conversation

matejvasek
Copy link
Contributor

Signed-off-by: Matej Vasek [email protected]

@matejvasek
Copy link
Contributor Author

/cc @rhatdan

@TomSweeneyRedHat
Copy link
Member

@baude @jwhonce PTAL

@matejvasek
Copy link
Contributor Author

@mheon @jwhonce PTAL

@matejvasek matejvasek mentioned this pull request Feb 17, 2021
Merged
@matejvasek
Copy link
Contributor Author

/hold this is related to some ongoing PR, it's possible the API change will be reverted.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
matejvasek
matejvasek commented Feb 18, 2021
View reviewed changes
pkg/api/server/register_containers.go
// - stopped
// type: array
// items:
// type: string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I could use named type as items: using $ref: but for query param it seems not to pass validation, although generators happily generate code 😞

@matejvasek
Copy link
Contributor Author

Should I add [CI:DOCS] to this issue?

@matejvasek
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2021
@matejvasek matejvasek changed the title [NO TESTS NEEDED] Update doc for libpod container wait Update swagger doc for libpod container wait Feb 18, 2021
@matejvasek matejvasek force-pushed the update_wait_swagger branch 2 times, most recently from 75c8d44 to fbf98c0 Compare February 18, 2021 17:07
@matejvasek matejvasek changed the title Update swagger doc for libpod container wait [CI:DOCS] Update swagger doc for libpod container wait Feb 18, 2021
@matejvasek
Copy link
Contributor Author

The API revert PR was resolved and I updated this PR accordingly.

matejvasek
matejvasek commented Feb 18, 2021
View reviewed changes
pkg/api/server/register_containers.go
// - exited
// - removing
// - stopping
// description: "Conditions to wait for. If no condition provided the 'exited' condition is assumed."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check wording.

@matejvasek
Copy link
Contributor Author

@jwhonce @mheon PTAL

@matejvasek
Copy link
Contributor Author

@edigaryev Here, I am updating doc.

@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2021

LGTM
@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Feb 19, 2021

LGTM on my end, but would prefer @jwhonce or @baude merge

@jwhonce
Copy link
Member

jwhonce commented Feb 19, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@rhatdan rhatdan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4aaaa6c into containers:master Feb 19, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matejvasek @TomSweeneyRedHat @rhatdan @mheon @jwhonce @openshift-ci-robot @openshift-merge-robot