Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci:docs] Update rootless_tutorial.md #9335

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

rlukin
Copy link
Contributor

@rlukin rlukin commented Feb 12, 2021

No description provided.

@rlukin
Copy link
Contributor Author

rlukin commented Feb 12, 2021

/assign @edsantiago

@rhatdan
Copy link
Member

rhatdan commented Feb 12, 2021

Thanks, but you have to sign your commits.

git commit -a --amend -s
git push --force

@rhatdan
Copy link
Member

rhatdan commented Feb 12, 2021

Adding a little comment about what you are fixing also, would be helpful.

@edsantiago
Copy link
Member

Thanks for your PR, @rlukin!

Would you mind running:

$ git commit --amend -s
[add a commit message describing the problem you're addressing with this]
$ git push --force

The -s will add a Signed-off-by footer as required by our contributing guidelines. The commit message will help a future maintenance programmer scrolling through the commit history.

@rhatdan rhatdan changed the title Update rootless_tutorial.md [ci:docs] Update rootless_tutorial.md Feb 16, 2021
Signed-off-by: Roman Lukin <[email protected]>
@rlukin
Copy link
Contributor Author

rlukin commented Feb 21, 2021

@rhatdan @edsantiago done

@rhatdan
Copy link
Member

rhatdan commented Feb 22, 2021

Thanks @rlukin
LGTM
@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@rhatdan rhatdan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rlukin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5da7c69 into containers:master Feb 22, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants