Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default template functions #9313

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Feb 10, 2021

This catches master up to v3.0.0

For commands that use the golang template library directly add the
compatible template functions

Fixes #8773

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce requested a review from baude February 10, 2021 22:04
@jwhonce jwhonce self-assigned this Feb 10, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021
@TomSweeneyRedHat
Copy link
Member

LGTM
but f33 tests aren't hip

@rhatdan
Copy link
Member

rhatdan commented Feb 10, 2021

Please add a test.

@vrothberg
Copy link
Member

Friendly ping

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Mar 29, 2021

@jwhonce Please fix this up so we can merge?

For commands that use the golang template library directly add the
compatible template functions

[NO TESTS NEEDED]

Fixes containers#8773

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce
Copy link
Member Author

jwhonce commented Apr 2, 2021

@rhatdan Done

@baude
Copy link
Member

baude commented Apr 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3fae801 into containers:master Apr 5, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Output formatting no longer supports join (Go template)
7 participants