apiv2 test fixes #9289
apiv2 test fixes #9289
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold DO NOT MERGE (yet) - this PR is based on #9270. (I don't actually depend on it, in fact it's probably the converse, but I'd like that one to go in first because it's been in the pipeline for longer). If for any reason #9270 fails CI or review I'll need to resubmit this, and will then decide whether to rebase on master (and have 9270 rebase here) or whether to rebase on a changed 9270. I am gambling on 9270 passing CI and review. |
openshift-ci-robot
added
the
do-not-merge/hold
Docker doesn't have the destination parameter as libpod does, the "image name" path parameter is supposed to be the destination. Signed-off-by: Matej Vasek <[email protected]>
It's been a while since I last looked at these; some cruft
has crept in, generating noise and hence unreadable test
results. Clean it up:
* remove pushd/popd in one subtest, replace with 'tar -C'.
(Also remove confusing quotation marks). This removes
spurious directory names from output.
* in like(), show only first line of actual output.
Some commands ('tree', 'generate kube') produce
voluminous multi-line output, which is super useless
and distracting when reading a test run.
* Recognize that some queries will not generate output,
e.g. HEAD requests and some POSTs. Deal with that.
This fixes "curl.result.out: no such file" and "parse
error" warnings.
* In cleanup, 'podman rm -a' and 'rmi -af'; this gets
rid of errors when deleting $WORKDIR. (EBUSY error
when root, EPERM when rootless).
And, the original reason for poking in here: refactor the
wait-for-port part of start_server() into its own helper
function, so we can use it when starting a local registry
in 12-imagesMore. (Ref: containers#9270)
Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
apiv2_test_fixes
branch
from
06000f1 to
ea704da
Compare
|
Confirmed: much nicer cleaner test log |
|
LGTM |
|
/hold cancel #9270 is merged, so this should merge cleanly. Tests are green. @containers/podman-maintainers PTAL |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
It's been a while since I last looked at these; some cruft
has crept in, generating noise and hence unreadable test
results. Clean it up:
remove pushd/popd in one subtest, replace with 'tar -C'.
(Also remove confusing quotation marks). This removes
spurious directory names from output.
in like(), show only first line of actual output.
Some commands ('tree', 'generate kube') produce
voluminous multi-line output, which is super useless
and distracting when reading a test run.
Recognize that some queries will not generate output,
e.g. HEAD requests and some POSTs. Deal with that.
This fixes "curl.result.out: no such file" and "parse
error" warnings.
In cleanup, 'podman rm -a' and 'rmi -af'; this gets
rid of errors when deleting $WORKDIR. (EBUSY error
when root, EPERM when rootless).
And, the original reason for poking in here: refactor the
wait-for-port part of start_server() into its own helper
function, so we can use it when starting a local registry
in 12-imagesMore. (Ref: #9270)
Signed-off-by: Ed Santiago [email protected]