Implement missing arguments for podman build #9246
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Fixes: #9247 |
|
LGTM once tests go green. Good candidate for a 3.0 backport if done in time, but I don't want to hold the release for it. |
|
Yes this also needs a buildah revendor, so this should go in post rc3. |
| Out: stdout, | ||
| Output: output, | ||
| OutputFormat: format, | ||
| PullPolicy: pullPolicy, | ||
| PullPushRetryDelay: 2 * time.Second, |
There was a problem hiding this comment.
I should have done this on the last review, but just looking at the buildah bud man page, I'm not seeing
--squash-all, and --variant, did we miss those? In addition, I'm not seeing --stdin documentation in buildah bud's man page.
There was a problem hiding this comment.
Yes there are others missing. Let's get this merged and we can continue adding the others. My next PR should cleanup some more.
rhatdan
force-pushed
the
build
branch
2 times, most recently
from
2e94ba1 to
331e24a
Compare
Buildah bud passes a bunch more flags then podman build. We need to implement hook up all of these flags to get full functionality. Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
|
LGTM |
github-actions
bot
added
the
locked - please file new issue/PR
Buildah bud passes a bunch more flags then podman build.
We need to implement hook up all of these flags to get full functionality.
Signed-off-by: Daniel J Walsh [email protected]