add network prune #9236
Merged
add network prune #9236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Luap99
reviewed
Feb 4, 2021
jwhonce
requested changes
Feb 4, 2021
Luap99
reviewed
Feb 4, 2021
Luap99
reviewed
Feb 4, 2021
baude
force-pushed
the
networkprune
branch
2 times, most recently
from
cafbf6f to
25e4e6a
Compare
| podman(1), podman-network(1), podman-network-remove(1) | ||
|
|
||
| ## HISTORY | ||
| February 2021, Originally compiled by Brent Baude <[email protected]> |
There was a problem hiding this comment.
It would be good to have a --unused option for podman network list or an option here (--preview?) to show the ones that would be pruned if the command was called.
baude
force-pushed
the
networkprune
branch
3 times, most recently
from
89de5d0 to
731501f
Compare
add the ability to prune unused cni networks. filters are not implemented but included both compat and podman api endpoints. Fixes :containers#8673 Signed-off-by: baude <[email protected]>
| @@ -80,3 +80,15 @@ type NetworkConnectOptions struct { | |||
| Aliases []string | |||
| Container string | |||
| } | |||
|
|
|||
| // NetworkPruneReport containers the name of network and an error | |||
There was a problem hiding this comment.
nit
Suggested change
| // NetworkPruneReport containers the name of network and an error | |
| // NetworkPruneReport contains the name of the network and an error |
|
LGTM |
|
LGTM |
|
merge? |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the ability to prune unused cni networks. filters are not implemented
but included both compat and podman api endpoints.
Fixes :#8673
Signed-off-by: baude [email protected]